Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump eslint to ^9.11.1 and migrate to flat config #4727

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

Bump eslint to ^9.11.1 and migrate to flat config #4727

wants to merge 12 commits into from
+925 −991

Conversation

MajorLift
Copy link
Contributor

@MajorLift MajorLift commented Sep 24, 2024 •
edited
Loading

Explanation

References

Changelog

@metamask/package-a

  • : Your change here
  • : Your change here

@metamask/package-b

  • : Your change here
  • : Your change here

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@socket-security Socket Security
Copy link

socket-security bot commented Sep 24, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@es-joy/jsdoccomment@0.48.0 None 0 121 kB brettz9
npm/@eslint-community/regexpp@4.11.1 None 0 446 kB eslint-community-bot
npm/@eslint/config-array@0.18.0 None 0 113 kB eslintbot
npm/@eslint/core@0.6.0 None 0 36 kB eslintbot
npm/@eslint/eslintrc@3.1.0 filesystem, unsafe 0 668 kB eslintbot
npm/@eslint/js@9.11.1 None 0 14.2 kB eslintbot, openjsfoundation
npm/@eslint/object-schema@2.1.4 None 0 55.5 kB eslintbot
npm/@eslint/plugin-kit@0.2.0 None 0 76.7 kB eslintbot
npm/@humanwhocodes/retry@0.3.0 None 0 44.3 kB nzakas
npm/@nolyfill/is-core-module@1.0.39 unsafe 0 2.71 kB sukkaw
npm/@typescript-eslint/eslint-plugin@8.7.0 None 0 2.65 MB bradzacher, jameshenry
npm/@typescript-eslint/parser@8.7.0 None 0 18.7 kB bradzacher, jameshenry
npm/@typescript-eslint/scope-manager@8.7.0 None 0 602 kB bradzacher, jameshenry
npm/@typescript-eslint/type-utils@8.7.0 None 0 121 kB bradzacher, jameshenry
npm/@typescript-eslint/types@8.7.0 None 0 171 kB jameshenry
npm/@typescript-eslint/typescript-estree@8.7.0 None 0 587 kB bradzacher, jameshenry
npm/@typescript-eslint/utils@8.7.0 None 0 283 kB bradzacher, jameshenry
npm/@typescript-eslint/visitor-keys@8.7.0 None 0 19.5 kB bradzacher, jameshenry
npm/are-docs-informative@0.0.2 None 0 13.6 kB joshuakgoldberg
npm/babel-jest@29.7.0 environment 0 13.5 kB simenb
npm/comment-parser@1.4.1 None 0 366 kB yavorskiys
npm/enhanced-resolve@5.17.1 unsafe 0 212 kB evilebottnawi
npm/es-module-lexer@1.5.4 None 0 90.9 kB guybedford
npm/eslint-compat-utils@0.5.1 filesystem 0 53.1 kB ota-meshi
npm/eslint-config-prettier@9.1.0 None 0 20.8 kB lydell
npm/eslint-import-resolver-typescript@3.6.3 None 0 46.8 kB jounqin
npm/eslint-module-utils@2.11.1 None 0 54.4 kB ljharb
npm/eslint-plugin-es-x@7.8.0 None 0 409 kB eslint-community-bot
npm/eslint-plugin-import-x@4.3.0 None 0 683 kB jounqin
npm/eslint-plugin-jsdoc@50.2.4 None 0 2.08 MB gajus
npm/eslint-plugin-n@17.10.3 None 0 437 kB eslint-community-bot, weiran.zsd
npm/eslint-plugin-prettier@5.2.1 None 0 34.3 kB jounqin
npm/eslint-plugin-promise@7.1.0 None 0 77.7 kB eslint-community-bot
npm/eslint-scope@8.0.2 None 0 148 kB eslintbot
npm/eslint@9.11.1 environment 0 3.3 MB eslintbot
npm/espree@10.1.0 None 0 76.5 kB eslintbot
npm/file-entry-cache@8.0.0 filesystem 0 16 kB jaredwray
npm/flat-cache@4.0.1 filesystem 0 29.3 kB jaredwray
npm/get-tsconfig@4.8.1 filesystem 0 105 kB hirokiosame
npm/globby@13.2.2 None 0 25.1 kB sindresorhus
npm/is-bun-module@1.2.1 None 0 11.7 kB sunset_techuila
npm/jsdoc-type-pratt-parser@4.1.0 None 0 245 kB jsdoc-type-pratt-parser
npm/parse-imports@2.2.1 None 0 39.1 kB tomeraberbach
npm/prettier@3.3.3 environment, filesystem, unsafe 0 7.7 MB prettier-bot
npm/resolve-pkg-maps@1.0.0 None 0 15 kB hirokiosame
npm/slashes@3.0.12 None 0 26 kB chrisackerman
npm/stable-hash@0.0.4 None 0 5.46 kB quietshu
npm/tapable@2.2.1 None 0 46.9 kB sokra
npm/ts-api-utils@1.3.0 None 0 828 kB joshuakgoldberg
npm/typescript-eslint@8.7.0 None 0 99.5 kB jameshenry

🚮 Removed packages: npm/@es-joy/jsdoccomment@0.36.1, npm/@eslint-community/regexpp@4.11.0, npm/@eslint/js@8.57.0, npm/@humanwhocodes/config-array@0.11.14, npm/@metamask/eslint-config-jest@12.1.0, npm/@metamask/eslint-config-nodejs@12.1.0, npm/@metamask/eslint-config-typescript@12.1.0, npm/@metamask/eslint-config@12.2.0, npm/@types/json5@0.0.29, npm/@typescript-eslint/eslint-plugin@5.62.0, npm/@typescript-eslint/parser@5.62.0, npm/@typescript-eslint/scope-manager@5.62.0, npm/@typescript-eslint/type-utils@5.62.0, npm/@typescript-eslint/types@5.62.0, npm/@typescript-eslint/typescript-estree@5.62.0, npm/@typescript-eslint/utils@5.62.0, npm/@typescript-eslint/visitor-keys@5.62.0, npm/array-buffer-byte-length@1.0.1, npm/array-includes@3.1.8, npm/array.prototype.flat@1.3.2, npm/arraybuffer.prototype.slice@1.0.3, npm/babel-jest@27.5.1, npm/builtins@5.1.0, npm/comment-parser@1.3.1, npm/data-view-buffer@1.0.1, npm/data-view-byte-length@1.0.1, npm/data-view-byte-offset@1.0.0, npm/es-abstract@1.23.3, npm/es-object-atoms@1.0.0, npm/es-set-tostringtag@2.0.3, npm/es-shim-unscopables@1.0.2, npm/es-to-primitive@1.2.1, npm/eslint-config-prettier@8.10.0, npm/eslint-import-resolver-typescript@2.7.1, npm/eslint-module-utils@2.8.2, npm/eslint-plugin-es@4.1.0, npm/eslint-plugin-import@2.26.0, npm/eslint-plugin-jsdoc@39.9.1, npm/eslint-plugin-n@15.7.0, npm/eslint-plugin-prettier@4.2.1, npm/eslint-plugin-promise@6.6.0, npm/eslint-scope@5.1.1, npm/eslint-utils@2.1.0, npm/eslint@8.57.0, npm/function.prototype.name@1.1.6, npm/functions-have-names@1.2.3, npm/get-symbol-description@1.0.2, npm/globalthis@1.0.4, npm/globby@11.1.0, npm/has-bigints@1.0.2, npm/has@1.0.4, npm/internal-slot@1.0.7, npm/is-array-buffer@3.0.4, npm/is-bigint@1.0.4, npm/is-boolean-object@1.1.2, npm/is-data-view@1.0.1, npm/is-date-object@1.0.5, npm/is-negative-zero@2.0.3, npm/is-number-object@1.0.7, npm/is-regex@1.1.4, npm/is-shared-array-buffer@1.0.3, npm/is-string@1.0.7, npm/is-symbol@1.0.4, npm/is-weakref@1.0.2, npm/isarray@2.0.5, npm/jsdoc-type-pratt-parser@3.1.0, npm/minimist@1.2.8, npm/natural-compare-lite@1.4.0, npm/object.values@1.2.0, npm/regexp.prototype.flags@1.5.2, npm/regexpp@3.2.0, npm/safe-array-concat@1.1.2, npm/safe-regex-test@1.0.3, npm/set-function-name@2.0.2, npm/string.prototype.trim@1.2.9, npm/string.prototype.trimend@1.0.8, npm/string.prototype.trimstart@1.0.8, npm/tsconfig-paths@3.15.0, npm/tsutils@3.21.0, npm/typed-array-buffer@1.0.2, npm/typed-array-byte-length@1.0.1, npm/typed-array-byte-offset@1.0.2, npm/typed-array-length@1.0.6, npm/unbox-primitive@1.0.2, npm/which-boxed-primitive@1.0.2

View full report↗︎

@socket-security Socket Security
Copy link

socket-security bot commented Sep 24, 2024 •
edited
Loading

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteCI
Deprecated npm/rimraf@3.0.2
  • Reason: Rimraf versions prior to v4 are no longer supported
⚠︎
Deprecated npm/glob@7.2.3
  • Reason: Glob versions prior to v9 are no longer supported
⚠︎
Deprecated npm/inflight@1.0.6
  • Reason: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
⚠︎

View full report↗︎

Next steps

What is a deprecated package?

The maintainer of the package marked it as deprecated. This could indicate that a single version should not be used, or that the package is no longer maintained and any new vulnerabilities will not be fixed.

Research the state of the package and determine if there are non-deprecated versions that can be used, or if it should be replaced with a new, supported solution.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/rimraf@3.0.2
  • @SocketSecurity ignore npm/glob@7.2.3
  • @SocketSecurity ignore npm/inflight@1.0.6

@MajorLift MajorLift force-pushed the jongsun/preview/240924-eslint9 branch 2 times, most recently from bf0f6eb to a680d66 Compare September 24, 2024 17:06
@MajorLift MajorLift changed the title [DNM] preview/eslint9 Bump eslint to ^9.11.1 and migrate to flat config Sep 30, 2024
@MajorLift MajorLift self-assigned this Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@MajorLift MajorLift

Labels
DO-NOT-MERGE team-wallet-framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ESLint config format is deprecated
1 participant
@MajorLift